Skip to content

Route Z-Image ControlNet diagnostics through logging - #9289

Closed
wunianze666-netizen wants to merge 1 commit into
invoke-ai:mainfrom
wunianze666-netizen:fix/z-image-controlnet-logging
Closed

wunianze666-netizen wants to merge 1 commit into
invoke-ai:mainfrom
wunianze666-netizen:fix/z-image-controlnet-logging

Conversation

@wunianze666-netizen

Copy link
Copy Markdown
Contributor

Summary

  • replace unconditional [DEBUG] / [WARNING] terminal output in z_image_controlnet_extension.py with module logger calls
  • add a regression test that checks initialization diagnostics do not write to stdout and still emit logging calls

Why

These diagnostics come from backend/library code and currently print directly to stdout, which can pollute terminal output and make log handling inconsistent for downstream callers.

Validation

  • added a regression test for constructor diagnostics behavior
  • verified the updated source and test files with py_compile
  • ran a source-level regression check to confirm the debug output is no longer implemented with direct print(...) calls

Note

The full pytest dependency set for this repository was not available in the current local environment, so I validated this change with targeted static checks plus compile-time verification.

@github-actions github-actions Bot added python PRs that change python files backend PRs that change backend files python-tests PRs that change python tests labels Jun 13, 2026
@lstein lstein added the 6.14.0 label Jun 17, 2026
@lstein lstein moved this to 6.14.x Theme: USER EXPERIENCE in Invoke - Community Roadmap Jun 17, 2026

@Pfannkuchensack Pfannkuchensack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Change.

@lstein

lstein commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@wunianze666-netizen
It looks like this PR was submitted without allowing maintainer access, and I don't have permission to update it with the latest base branch changes. Could you either check the "allow edits by maintainers", or rebase your branch and push it back to the PR? If you do the latter, please let me know on Discord ('lstein') so that I can get the PR merged before it goes out of date again.

@lstein

lstein commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #9298

@lstein lstein closed this Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.14.0 backend PRs that change backend files python PRs that change python files python-tests PRs that change python tests

Projects

Status: 6.14.x Theme: USER EXPERIENCE

Development

Successfully merging this pull request may close these issues.

3 participants