Conversation
The model name validator required more than 3 characters while its message said 'Must be at least 3 characters'; 3-character names are now accepted. The Save button is now gated on form validity, matching SystemPromptForm, instead of counting keys of the errors object.
leepokai
requested review from
JPPhoto,
Pfannkuchensack,
blessedcoolant,
dunkeroni and
lstein
as code owners
July 31, 2026 15:27
Author
|
Closing this — I won't be able to follow up on it. Sorry for the noise. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9364
Two changes in
ModelEdit.tsx:length > 3while its message says "Must be at least 3 characters" — 3-character names are now accepted (>= 3), matching the message (screenshots in the issue show 3 rejected / 4 accepted).formState.errors; it is now gated on!form.formState.isValid, the same pattern used bySystemPromptForm. This is the canonical react-hook-form validity subscription and addresses the reported "Save stays greyed out after deleting and retyping the name until you cancel".Related Issues / Discussions
#9364
QA Instructions
Model Manager → select a model → Edit → delete the whole name → retype 3+ characters → Save should enable; a 3-character name should be accepted.
Verification done here: reproduced the off-by-one and validated both fixes in an isolated harness using the repo's locked react-hook-form 7.69.0 + React 19.2.6 (clear → retype recovers; exactly 3 chars accepted);
pnpm lint(tsc/eslint/prettier) clean;pnpm test:no-watch1707/1707 passing. Note: I could not reproduce the stuck-button state in isolation with a plain input — it may depend on the ui-library composition — but the validity-based gate cannot wedge that way and matches the existing pattern in the codebase.Merge Plan
Simple frontend-only change, no special merge considerations.
Checklist