Uh oh!
There was an error while loading. Please reload this page.
add target to the button "Github Org" - #24
Conversation
Fishrock123
commented
Jan 12, 2015
Hmmm. @mikeal do we want to open things in new tabs? |
italoacasas
commented
Jan 12, 2015
@Fishrock123 all buttons open in a new tab, check the page. |
Fishrock123
commented
Jan 12, 2015
Sure, but is this actually something we want? It gets a little silly on mobile. |
italoacasas
commented
Jan 12, 2015
Ooo, anyway I think the biggest percentage of users are desk |
mikeal
commented
Jan 12, 2015
Why this link and no others? |
italoacasas
commented
Jan 12, 2015
The others are ready, I think this is forgotten |
therebelrobot
commented
Jan 15, 2015
@snostorm@Fishrock123 et al.: should we close old PRs that can't be auto merged and have the original author fix it, or should we do something ourselves to fix it? I want to avoid a bunch of old forgotten PRs that can't be merged filling up our PR page. |
Fishrock123
commented
Jan 15, 2015
@therebelrobot I'd say fix it ourselves if it's not much trouble. That's the policy I do from express. The PR doesn't make much sense anymore, we don't do this anywhere ATM. @italoacasas If you'd like to create a new PR for external-only links, that would be cool. |
snostorm
commented
Jan 16, 2015
@therebelrobot I say we close after some sort of X day policy. First maybe tag the author to try and rebase/conflict resolve before closing? To me a close feels like a slight rejection. I've been known to cherry-pick an easy change and just apply it myself, giving the original person git author credit. (Easier/quicker than the turnaround of waiting for them to fix.) Let's add this to the agenda? (closing/fixing policy, not external links) |
No description provided.