Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

add target to the button "Github Org" - #24

Closed
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:master
Closed

add target to the button "Github Org"#24
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:master

Conversation

@italoacasas

Copy link
Copy Markdown

No description provided.

@Fishrock123

Copy link
Copy Markdown
Contributor

Hmmm. @mikeal do we want to open things in new tabs?

@italoacasas

Copy link
Copy Markdown
Author

@Fishrock123 all buttons open in a new tab, check the page.

@Fishrock123

Copy link
Copy Markdown
Contributor

Sure, but is this actually something we want? It gets a little silly on mobile.

@italoacasas

Copy link
Copy Markdown
Author

Ooo, anyway I think the biggest percentage of users are desk

@mikeal

Copy link
Copy Markdown
Contributor

Why this link and no others?

@italoacasas

Copy link
Copy Markdown
Author

The others are ready, I think this is forgotten

@therebelrobot

Copy link
Copy Markdown
Contributor

@snostorm@Fishrock123 et al.: should we close old PRs that can't be auto merged and have the original author fix it, or should we do something ourselves to fix it? I want to avoid a bunch of old forgotten PRs that can't be merged filling up our PR page.

@Fishrock123

Copy link
Copy Markdown
Contributor

@therebelrobot I'd say fix it ourselves if it's not much trouble. That's the policy I do from express.

The PR doesn't make much sense anymore, we don't do this anywhere ATM.

@italoacasas If you'd like to create a new PR for external-only links, that would be cool.

@snostorm

Copy link
Copy Markdown
Contributor

@therebelrobot I say we close after some sort of X day policy. First maybe tag the author to try and rebase/conflict resolve before closing? To me a close feels like a slight rejection.

I've been known to cherry-pick an easy change and just apply it myself, giving the original person git author credit. (Easier/quicker than the turnaround of waiting for them to fix.)

Let's add this to the agenda? (closing/fixing policy, not external links)

@therebelrobottherebelrobot mentioned this pull request Jan 16, 2015
snostorm pushed a commit that referenced this pull request Feb 27, 2015
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@italoacasas@Fishrock123@mikeal@therebelrobot@snostorm