Skip to content

docs(config): add examples on overriding config per-platform - #1423

Merged
liamdebeasi merged 10 commits into
masterfrom
config-platform
Jun 10, 2020
Merged

docs(config): add examples on overriding config per-platform#1423
liamdebeasi merged 10 commits into
masterfrom
config-platform

Conversation

@liamdebeasi

@liamdebeasiliamdebeasi commented May 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

@liamdebeasiliamdebeasi mentioned this pull request May 15, 2020
Merged
13 tasks
@perrygovier
perrygovier temporarily deployed to ionic-docs-pr-1423 May 15, 2020 14:56 Inactive
@perrygovier
perrygovier temporarily deployed to ionic-docs-pr-1423 May 15, 2020 14:57 Inactive
@perrygovier
perrygovier temporarily deployed to ionic-docs-pr-1423 May 15, 2020 15:46 Inactive
brandyscarney
brandyscarney reviewed May 15, 2020
View reviewed changes

@brandyscarneybrandyscarney left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename React's heading to just Platform to match Angular's?

Comment threadsrc/pages/angular/config.md Outdated
@perrygovier
perrygovier temporarily deployed to ionic-docs-pr-1423 May 15, 2020 16:51 Inactive
@perrygovier
perrygovier temporarily deployed to ionic-docs-pr-1423 May 18, 2020 17:10 Inactive
brandyscarney
brandyscarney reviewed May 19, 2020
View reviewed changes
Comment threadsrc/pages/react/config.md
Comment threadsrc/pages/react/config.md Outdated
Comment threadsrc/pages/angular/config.md Outdated
Comment threadsrc/pages/react/platform.md Outdated

## Platforms

Below is a table listing all the possible `Platforms` values along with corresponding descriptions.

@brandyscarneybrandyscarneyMay 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Platforms in a code block?

@liamdebeasiliamdebeasiMay 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? I don't see in a code block.

@brandyscarneybrandyscarneyMay 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't let me add a SS here but this:

Below is a table listing all the possible Platforms values along with corresponding descriptions.

Platforms

liamdebeasiand others added 2 commits May 20, 2020 13:09
@liamdebeasi@brandyscarney
Update src/pages/angular/config.md
d6549c0
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi@brandyscarney
Update src/pages/react/config.md
315a5e9
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@perrygovier
perrygovier temporarily deployed to ionic-docs-pr-1423 May 20, 2020 17:09 Inactive
@perrygovier
perrygovier temporarily deployed to ionic-docs-pr-1423 May 20, 2020 17:21 Inactive
brandyscarney
brandyscarney approved these changes May 21, 2020
View reviewed changes
Comment threadsrc/pages/react/config.md
Comment threadsrc/pages/react/platform.md Outdated

## Platforms

Below is a table listing all the possible `Platforms` values along with corresponding descriptions.

@brandyscarneybrandyscarneyMay 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't let me add a SS here but this:

Below is a table listing all the possible Platforms values along with corresponding descriptions.

Platforms

@liamdebeasiliamdebeasi mentioned this pull request May 22, 2020
Closed
@liamdebeasi
liamdebeasi merged commit 5f86584 into masterJun 10, 2020
@liamdebeasi
liamdebeasi deleted the config-platform branch June 10, 2020 17:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarneybrandyscarneybrandyscarney approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liamdebeasi@brandyscarney@perrygovier