Skip to content

docs(nav): nav link component playground - #2437

Merged
sean-perkins merged 8 commits into
docs/nav-playgroundfrom
docs/nav-link-playground
Jul 6, 2022
Merged

docs(nav): nav link component playground#2437
sean-perkins merged 8 commits into
docs/nav-playgroundfrom
docs/nav-link-playground

Conversation

@sean-perkins

@sean-perkinssean-perkins commented Jul 6, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Quick link: https://ionic-docs-git-docs-nav-link-playground-ionic1.vercel.app/docs/api/nav#using-navlink

To verify the React example, you will need to manually install the dev-build: 6.1.12-dev.11656705976.18fe5a46

@vercel

vercelBot commented Jul 6, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
ionic-docs✅ Ready (Inspect)Visit PreviewJul 6, 2022 at 5:45PM (UTC)

@sean-perkins
sean-perkins marked this pull request as ready for review July 6, 2022 02:13
averyrousseau
averyrousseau suggested changes Jul 6, 2022
View reviewed changes
Comment threaddocs/api/nav.md
Comment threadstatic/usage/nav/nav-link/vue/page_three_vue.md Outdated
Comment threadstatic/usage/nav/nav-link/vue/page_two_vue.md Outdated
Comment threadstatic/usage/nav/nav-link/angular/page_one_component_ts.md
Comment threadstatic/usage/nav/nav-link/react/page_two_tsx.md
liamdebeasi
liamdebeasi approved these changes Jul 6, 2022
View reviewed changes

@liamdebeasiliamdebeasi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as Amanda. Otherwise looks great. Nice job!

averyrousseau
averyrousseau approved these changes Jul 6, 2022
View reviewed changes

@averyrousseauaveryrousseau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now!

@sean-perkins
sean-perkins merged commit 550396c into docs/nav-playgroundJul 6, 2022
@sean-perkins
sean-perkins deleted the docs/nav-link-playground branch July 6, 2022 20:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@liamdebeasiliamdebeasiliamdebeasi approved these changes
@averyrousseauaveryrousseauaveryrousseau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sean-perkins@liamdebeasi@averyrousseau