Skip to content

fix(skeleton-text): use component name for files - #2523

Merged
liamdebeasi merged 9 commits into
mainfrom
skeleton-path
Sep 1, 2022
Merged

fix(skeleton-text): use component name for files#2523
liamdebeasi merged 9 commits into
mainfrom
skeleton-path

Conversation

@liamdebeasi

@liamdebeasiliamdebeasi commented Sep 1, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

The skeleton text demos were being added to app.component.html which overrides the injected ion-app. This PR fixes that so skeleton text demos get added to the app-example component instead.

Also fixed file names to be more consistent with the other playgrounds.

@vercel

vercelBot commented Sep 1, 2022

Copy link
Copy Markdown

Deployment failed with the following error:

Invalid vercel.json file provided

@liamdebeasi
liamdebeasi marked this pull request as ready for review September 1, 2022 17:57
@liamdebeasiliamdebeasi reopened this Sep 1, 2022
@vercel

vercelBot commented Sep 1, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
ionic-docs✅ Ready (Inspect)Visit PreviewSep 1, 2022 at 6:59PM (UTC)

brandyscarney
brandyscarney requested changes Sep 1, 2022
View reviewed changes
Comment threadstatic/usage/skeleton-text/theming/index.md Outdated
Comment threadstatic/usage/skeleton-text/theming/index.md Outdated
Comment threadstatic/usage/skeleton-text/theming/index.md Outdated
liamdebeasiand others added 3 commits September 1, 2022 14:47
@liamdebeasi@brandyscarney
Update static/usage/skeleton-text/theming/index.md
9f3fe68
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi@brandyscarney
Update static/usage/skeleton-text/theming/index.md
b93d727
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi
chore(): underscores
6102dcb
@liamdebeasi
liamdebeasi merged commit 01dd2f5 into mainSep 1, 2022
@liamdebeasi
liamdebeasi deleted the skeleton-path branch September 1, 2022 19:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarneybrandyscarneybrandyscarney approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liamdebeasi@brandyscarney