Skip to content

docs(breadcrumbs): fix theming headings - #2526

Merged
liamdebeasi merged 8 commits into
mainfrom
liamdebeasi-patch-1
Sep 14, 2022
Merged

docs(breadcrumbs): fix theming headings#2526
liamdebeasi merged 8 commits into
mainfrom
liamdebeasi-patch-1

Conversation

@liamdebeasi

@liamdebeasiliamdebeasi commented Sep 1, 2022

Copy link
Copy Markdown
Contributor
  • Updates "Styling" heading to read "Theming"
  • Updates the "Color Property" heading to display as a sub-heading in "Styling"

@vercel

vercelBot commented Sep 1, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
ionic-docs✅ Ready (Inspect)Visit PreviewSep 13, 2022 at 7:48PM (UTC)

@liamdebeasi
liamdebeasi marked this pull request as ready for review September 1, 2022 21:07
averyrousseau
averyrousseau approved these changes Sep 1, 2022
View reviewed changes

@averyrousseauaveryrousseau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "CSS Properties" header under "Color Property" also be changed to a 3rd level heading? Otherwise/including that, LGTM.

@liamdebeasi

liamdebeasi commented Sep 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Good catch, just fixed that.

@brandyscarney

brandyscarney commented Sep 1, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Can we rename the styling folder to theming to make it easier to find later on?

Also are we set on Color Property vs Colors or something similar?

@liamdebeasi

liamdebeasi commented Sep 1, 2022

Copy link
Copy Markdown
ContributorAuthor

I updated the directory name.

I don't really have a preference for Color Property vs Colors. I'm fine with whatever you think is best.

brandyscarney
brandyscarney reviewed Sep 2, 2022
View reviewed changes
Comment threaddocs/api/breadcrumbs.md Outdated
brandyscarney
brandyscarney reviewed Sep 2, 2022
View reviewed changes
Comment threaddocs/api/breadcrumbs.md Outdated
@brandyscarneybrandyscarney mentioned this pull request Sep 6, 2022
Merged
liamdebeasiand others added 2 commits September 9, 2022 09:43
@liamdebeasi@brandyscarney
Update docs/api/breadcrumbs.md
7bae017
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi
chore(): update directory name
52263bd
brandyscarney
brandyscarney reviewed Sep 9, 2022
View reviewed changes
Comment threaddocs/api/breadcrumbs.md Outdated
@liamdebeasi@brandyscarney
Update docs/api/breadcrumbs.md
3d9af42
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@brandyscarney

brandyscarney commented Sep 12, 2022

Copy link
Copy Markdown
Member

Pushed some changes and approved, maybe we need @sean-perkins to help us update this for the jp version?

@liamdebeasi
liamdebeasi merged commit 70045f8 into mainSep 14, 2022
@liamdebeasi
liamdebeasi deleted the liamdebeasi-patch-1 branch September 14, 2022 19:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarneybrandyscarneybrandyscarney approved these changes
+1 more reviewer
@averyrousseauaveryrousseauaveryrousseau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liamdebeasi@brandyscarney@averyrousseau