Uh oh!
There was an error while loading. Please reload this page.
docs(slides): update React and Vue migration guides to be compatible with Swiper 9 - #2819
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
averyrousseau
marked this pull request as ready for review
March 13, 2023 18:07
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
liamdebeasi
approved these changes
Mar 13, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we decided to stick with Swiper's React/Vue components instead of Swiper Element for now, updating the guides for these two frameworks is mostly minor cleanup things. I also took the liberty of fixing some typos and adjusting the React docs to use the React-formatted component name.
Angular will be handled in a separate PR, as it will be a more significant overhaul to use Swiper Element instead. Updating the example repo linked at the bottom of the docs will also be done later. These changes should all be merged at the same time.