Skip to content

demo(list): add inset background color for dark mode - #3010

Closed
reslear wants to merge 1 commit into
ionic-team:mainfrom
reslear:patch-1
Closed

demo(list): add inset background color for dark mode#3010
reslear wants to merge 1 commit into
ionic-team:mainfrom
reslear:patch-1

Conversation

@reslear

Copy link
Copy Markdown
Contributor

also maybe need add this style to global ionic theme?

before after
Screenshot 2023-06-23 at 00 05 52Screenshot 2023-06-23 at 00 05 31

also maybe need add this style to global ionic theme?
@vercel

vercelBot commented Jun 22, 2023

Copy link
Copy Markdown

@reslear is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@reslearreslear changed the title add inset list background colordemo: add inset list background colorJun 22, 2023
@reslearreslear changed the title demo: add inset list background colordemo(list): add inset background color for dark modeJun 22, 2023
@liamdebeasi

Copy link
Copy Markdown
Contributor

Thanks for the PR! I was able to fix this using the light color palette on ion-content to account for both light and dark mode: #3015

I am going to close this in favor of the linked PR, but I will give you co-author credit when it merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@reslear@liamdebeasi