Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.2k
chore(docusaurus): upgrade to v3#3322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
adeb29561ecc2a9e3165cc0eac51c28a1f8e4ceb28e5f1d156b3c75c650eadb6e0cdb9aab8424ab3fb4e8afa52c3258f67b3c62beb5ea741File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -28,7 +28,7 @@ See the [Standalone Migration Guide](#migrating-from-modules-to-standalone) for | ||
| ### Usage with Standalone-based Applications | ||
| :::caution | ||
| :::warning | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Caution admonitions have been deprecated. It's recommended to use warning. | ||
| All Ionic imports should be imported from the `@ionic/angular/standalone` submodule. This includes imports such as components, directives, providers, and types. Importing from `@ionic/angular` may pull in lazy loaded Ionic code which can interfere with treeshaking. | ||
| ::: | ||
| @@ -177,7 +177,7 @@ export class HomePage {} | ||
| ### Usage with NgModule-based Applications | ||
| :::caution | ||
| :::warning | ||
| All Ionic imports should be imported from the `@ionic/angular/standalone` submodule. This includes imports such as components, directives, providers, and types. Importing from `@ionic/angular` may pull in lazy loaded Ionic code which can interfere with treeshaking. | ||
| ::: | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -19,9 +19,9 @@ Here’s the finished app running on all 3 platforms: | ||
| width="560" | ||
| height="315" | ||
| src="https://www.youtube.com/embed/0ASQ13Y1Rk4" | ||
| frameborder="0" | ||
| frameBorder="0" | ||
| allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture" | ||
| allowfullscreen | ||
| allowFullScreen | ||
Comment on lines
+22
to
+24
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed to remove a console error in the browser. | ||
| ></iframe> | ||
| :::note | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -41,9 +41,8 @@ Ionic apps are made of high-level building blocks called Components, which allow | ||
| </DocsCard> | ||
| <DocsCard header="Card" href="api/card" icon="/icons/component-card-icon.png"> | ||
| <p> | ||
| Cards are a great way to display an important piece of content, and can contain images, buttons, text, and more. | ||
| </p> | ||
| <!-- prettier-ignore --> | ||
| <p>Cards are a great way to display an important piece of content, and can contain images, buttons, text, and more.</p> | ||
Comment on lines
+44
to
+45
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MDX breaks when there are new lines within tags. Docusaurus recommends to either use | ||
| </DocsCard> | ||
| <DocsCard header="Checkbox" href="api/checkbox" icon="/icons/component-checkbox-icon.png"> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -2,6 +2,9 @@ | ||
| title: Updating to v4 | ||
| --- | ||
| import Tabs from '@theme/Tabs'; | ||
| import TabItem from '@theme/TabItem'; | ||
Comment on lines
+5
to
+6
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These were missing to begin with. It was evident with the upgrade b/c it would break the site without them. | ||
| # Updating to Ionic 4 | ||
| ## Updating from Ionic 3 to 4 | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DocPage has been replaced by DocRoot. The name is the only change that happened in Docusaurus v3.