Skip to content

docs: show how to account for this - #3334

Merged
liamdebeasi merged 7 commits into
feature-8.0from
8.0-thisctx
Dec 19, 2023
Merged

docs: show how to account for this#3334
liamdebeasi merged 7 commits into
feature-8.0from
8.0-thisctx

Conversation

@liamdebeasi

@liamdebeasiliamdebeasi commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

This is the same as #3333, but targets the Ionic 8 docs.

@vercel

vercelBot commented Dec 18, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
ionic-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 19, 2023 10:30pm

@liamdebeasi
liamdebeasi marked this pull request as ready for review December 18, 2023 20:23
@liamdebeasi
liamdebeasi requested a review from a team as a code ownerDecember 18, 2023 20:23
@liamdebeasi
liamdebeasi requested review from mapsandapps and removed request for a teamDecember 18, 2023 20:23
thetaPC
thetaPC requested changes Dec 18, 2023
View reviewed changes
Comment threaddocs/troubleshooting/runtime.md Outdated
Comment threadversioned_docs/version-v7/troubleshooting/runtime.md Outdated
liamdebeasiand others added 2 commits December 19, 2023 09:29
@liamdebeasi@thetaPC
Update docs/troubleshooting/runtime.md
d6ca1eb
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@liamdebeasi@thetaPC
Update versioned_docs/version-v7/troubleshooting/runtime.md
1e5c815
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
thetaPC
thetaPC approved these changes Dec 19, 2023
View reviewed changes

@thetaPCthetaPC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

averyrousseau
averyrousseau approved these changes Dec 19, 2023
View reviewed changes
Comment threaddocs/troubleshooting/runtime.md Outdated
Comment threadversioned_docs/version-v7/troubleshooting/runtime.md Outdated
liamdebeasiand others added 2 commits December 19, 2023 17:15
@liamdebeasi@averyrousseau
Update versioned_docs/version-v7/troubleshooting/runtime.md
8a1ab13
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
@liamdebeasi@averyrousseau
Update docs/troubleshooting/runtime.md
bcb5740
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
@liamdebeasi
liamdebeasi merged commit cd504bd into feature-8.0Dec 19, 2023
@liamdebeasi
liamdebeasi deleted the 8.0-thisctx branch December 19, 2023 22:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPCthetaPCthetaPC approved these changes
@mapsandappsmapsandappsAwaiting requested review from mapsandappsmapsandapps was automatically assigned from ionic-team/framework
+1 more reviewer
@averyrousseauaveryrousseauaveryrousseau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liamdebeasi@thetaPC@averyrousseau