Uh oh!
There was an error while loading. Please reload this page.
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
left a comment
There was a problem hiding this comment.
Looking good just a few suggestions!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Brandy Carney <6577830+brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Carney <6577830+brandyscarney@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Issue URL: internal
What is the current behavior?
The Angular documentation presents the Modules approach and
IonicModuleas a fully supported option with no indication that it is being phased out. The Build Options guide, the per config guides, and the Platform guide all showIonicModule.forRoot()examples, and the Ionic 9 upgrade guide does not mention the deprecation.What is the new behavior?
docs/angular/build-options.md: notes that the Modules approach andIonicModuleare deprecated as of Ionic 9, adds a Deprecation Notice admonition to the Modules section, and adds a code splitting note explaining the single entry point limitation of the standalone build.docs/updating/9-0.md: adds anIonicModuleDeprecation entry that points to the migration guide.docs/developing/config/*anddocs/angular/platform.md: add a deprecation comment above theIonicModuleexamples that points developers toprovideIonicAngular(). The Platform guide example is converted into Angular and Angular (Standalone) tabs so the standalone equivalent is shown alongside the Modules version.Does this introduce a breaking change?
Other information
Previews: