Uh oh!
There was an error while loading. Please reload this page.
docs(react): document typed overlay hook props and typescript 5.4 requirement - #4643
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
approved these changes
Aug 18, 2026
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
LGTM, non-blocker comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
brandyscarney
approved these changes
Aug 18, 2026
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looks good, just some optional changes!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, nothing documents that
useIonModalanduseIonPopovertypecomponentPropsagainst the component in v9, and the React support table still says TypeScript 3.7+.With this change, the v9 migration guide covers both,
docs/react/overlays.mdexplains where prop types are inferred from, and the support table moves to 5.4+ with a footnote. The two React playgrounds that passed props the new typing rejects are fixed.Note: this depends on the framework change landing first, so the guide describes type errors that don't happen yet.