Uh oh!
There was an error while loading. Please reload this page.
chore(archive): add missing lint ignores and document archiving - #4660
Open
thetaPC wants to merge 1 commit into
Open
chore(archive): add missing lint ignores and document archiving#4660thetaPC wants to merge 1 commit into
thetaPC wants to merge 1 commit into
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: N/A
What is the current behavior?
v7 was archived in #4647, but it was never added to
.prettierignoreorcspell.json, so Prettier and cspell still walk archived v7 content. Thestatic/usage/v6andv7playground folders were never ignored either.Separately, the framework landing redirects in
vercel.jsoncover v6 and v7 but not v8. No version ships an index page for those routes, so/docs/v8/angular,/docs/v8/react, and/docs/v8/vuecurrently fail to redirect to their overview pages, and/docs/v8/javascripthas no versioned redirect at all.The archiving instructions in
CONTRIBUTING.mdonly coveredversions.jsonandversionsArchived.json, which is how the v7 lint ignores were missed in the first place.What is the new behavior?
Config catch up:
.prettierignore: addsversioned_docs/version-v7,static/usage/v6, andstatic/usage/v7cspell.json: addsversioned_docs/version-v7vercel.json: adds v8 to theangular,react, andvuelanding redirects, and adds a v8 scopedjavascriptredirectThe archiving steps in
CONTRIBUTING.mdnow also coververcel.json,.prettierignore,cspell.json, andrenovate.json, so the next archive has a complete checklist.Does this introduce a breaking change?
Other information
Why the
vercel.jsonstep is ordered first. An archived version is served from a frozen Vercel deployment that ships its own copy ofvercel.json. A version scoped redirect therefore has to exist before the archive build, or it never reaches the archive and those links 404 there permanently. This is not hypothetical: v6 and v7 both work today only because the redirect pattern predates their most recent promoted builds.The v8 redirects fix a live issue. They are not only preparation for archiving v8. Those routes are broken on
mainright now, and archiving would have frozen the breakage in place.