Skip to content

refactor(ios): update toolbar and tabbar default background colors - #22852

Merged
liamdebeasi merged 6 commits into
nextfrom
header-tint
Feb 9, 2021
Merged

refactor(ios): update toolbar and tabbar default background colors#22852
liamdebeasi merged 6 commits into
nextfrom
header-tint

Conversation

@liamdebeasi

@liamdebeasiliamdebeasi commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

Starters: ionic-team/starters#1670
Docs: ionic-team/ionic-docs#1835

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves#22780

What is the new behavior?

  • Updated toolbar and tab bar default background colors (fallback values)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actionsgithub-actionsBot added the package: core @ionic/core package label Feb 1, 2021
@liamdebeasi

liamdebeasi commented Feb 1, 2021

Copy link
Copy Markdown
ContributorAuthor

Large Title

Light - Collapsed toolbar has changed from white to light gray
Dark - No changes

beforeafter
lightimageimage
darkimageimage

Toolbar

Light - Header and footer toolbars have changed from white to light gray
Dark - No changes

beforeafter
lightimageimage
darkimageimage

Tabbar

Light - Tab bar background has changed from white to light gray
Dark - Tab bar background has changed from black to dark gray

beforeafter
lightb-tab-ios-limage
darkimageimage

@liamdebeasiliamdebeasi changed the title breaking(ios): update toolbar and tabbar default background colorsrefactor(ios): update toolbar and tabbar default background colorsFeb 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core@ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@liamdebeasi