Skip to content

feat(accordion): add accordion and accordion-group components - #22865

Merged
liamdebeasi merged 67 commits into
nextfrom
feat-accordion
Mar 24, 2021
Merged

feat(accordion): add accordion and accordion-group components#22865
liamdebeasi merged 67 commits into
nextfrom
feat-accordion

Conversation

@liamdebeasi

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves#17094

What is the new behavior?

  • Add ion-accordion and ion-accordion-group components

Does this introduce a breaking change?

  • Yes
  • No

Other information

@brandyscarneybrandyscarney added this to the 6.0.0 milestone Mar 4, 2021
@liamdebeasi

liamdebeasi commented Mar 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Accessibility Testing

"native" refers to this sample: https://www.w3.org/TR/wai-aria-practices/examples/accordion/accordion.html

Selecting Accordion

nativeIonic
VoiceOver macOS - ChromePersonal information, collapsed, buttonPersonal information, collapsed, button
VoiceOver macOS - SafariPersonal information, collapsed, buttonPersonal information, collapsed, button
VoiceOver iOSPersonal information, collapsedPersonal information, button, main, landmark, collapsed
Android TalkBackCollapsed, personal information, buttonCollapsed, personal information, button
Windows NVDAPersonal information, button, unavailable, collapsedClickable Personal Information button collapsed

Toggling Accordion

nativeIonic
VoiceOver macOS - ChromePersonal information, dimmed expanded, buttonPersonal information, expanded, button
VoiceOver macOS - SafariPersonal information, dimmed expanded, buttonPersonal information, expanded, button
VoiceOver iOSPersonal information, dimmed, expandedPersonal information, main, landmark, expanded
Android TalkBackExpandedExpanded
Windows NVDAUnavailable, expandedExpanded

AXE Issues

None!

TODO:

  • NVDA prevents keyboard navigation from working with arrow keys

@liamdebeasi
liamdebeasi merged commit 073883a into nextMar 24, 2021
@liamdebeasi
liamdebeasi deleted the feat-accordion branch March 24, 2021 13:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular@ionic/angular packagepackage: core@ionic/core packagepackage: vue@ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@liamdebeasi@brandyscarney