Uh oh!
There was an error while loading. Please reload this page.
test(input): apply modern syntax updates - #27175
Merged
Merged
Conversation
|
sean-perkins
marked this pull request as ready for review
April 12, 2023 02:46
sean-perkins
enabled auto-merge
April 12, 2023 02:46
liamdebeasi
approved these changes
Apr 12, 2023
liamdebeasi pushed a commit
that referenced
this pull request
Apr 17, 2023
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There are tests for `ion-input` that are not in the `/legacy` test folder, that are using invalid modern syntax. Inversely, there is legacy tests that do not explicitly set `legacy="true"` that will be updated the modern syntax when #27156 is merged. <!-- Issues are required for both bug fixes and features. --> Issue URL: N/A ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updates modern tests to use modern label syntax (using `aria-label`) - Applies `legacy="true"` to legacy test templates - Fixes a typo in a legacy test where the selector was incorrect ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
liamdebeasi pushed a commit
that referenced
this pull request
Apr 19, 2023
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There are tests for `ion-input` that are not in the `/legacy` test folder, that are using invalid modern syntax. Inversely, there is legacy tests that do not explicitly set `legacy="true"` that will be updated the modern syntax when #27156 is merged. <!-- Issues are required for both bug fixes and features. --> Issue URL: N/A ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updates modern tests to use modern label syntax (using `aria-label`) - Applies `legacy="true"` to legacy test templates - Fixes a typo in a legacy test where the selector was incorrect ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
There are tests for
ion-inputthat are not in the/legacytest folder, that are using invalid modern syntax.Inversely, there is legacy tests that do not explicitly set
legacy="true"that will be updated the modern syntax when #27156 is merged.Issue URL: N/A
What is the new behavior?
aria-label)legacy="true"to legacy test templatesDoes this introduce a breaking change?
Other information