Skip to content

feat(input): add label slot - #27633

Merged
liamdebeasi merged 6 commits into
FW-4135from
4135-base
Jun 12, 2023
Merged

feat(input): add label slot#27633
liamdebeasi merged 6 commits into
FW-4135from
4135-base

Conversation

@liamdebeasi

@liamdebeasiliamdebeasi commented Jun 12, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue number: N/A

What is the current behavior?

Input only accepts plaintext labels.

What is the new behavior?

  • Input can now accept custom HTML labels via a slot

A few implementation notes:

  • Support for dynamically adding/removing slotted content will be added in a separate PR.
  • Support for the notch outline will be added in a separate PR.
  • The existing start/end placement label overflow tests were made redundant with the new tests I added. As a result, I removed the old tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz

bolt-new-by-stackblitzBot commented Jun 12, 2023

Copy link
Copy Markdown

Review PR in StackBlitz CodeflowRun & review this pull request in StackBlitz Codeflow.

@github-actionsgithub-actionsBot added the package: core @ionic/core package label Jun 12, 2023
@liamdebeasiliamdebeasi changed the title 4135 basefeat(input): add label slotJun 12, 2023
@liamdebeasi
liamdebeasi marked this pull request as ready for review June 12, 2023 14:32
@liamdebeasi
liamdebeasi requested review from a team, averyrousseau and brandyscarney and removed request for a team and brandyscarneyJune 12, 2023 14:40
brandyscarney
brandyscarney requested changes Jun 12, 2023
View reviewed changes
Comment threadcore/src/components/input/input.tsx Outdated
Comment threadcore/src/components/select/select.tsx Outdated
Comment threadcore/src/components/input/test/slot/index.html
Comment threadcore/src/components/input/test/slot/index.html
@liamdebeasi
liamdebeasi requested review from brandyscarney and removed request for averyrousseauJune 12, 2023 16:22
@liamdebeasi
liamdebeasi merged commit 1188234 into FW-4135Jun 12, 2023
@liamdebeasi
liamdebeasi deleted the 4135-base branch June 12, 2023 19:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarneybrandyscarneybrandyscarney approved these changes
+1 more reviewer
@sean-perkinssean-perkinssean-perkins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core@ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liamdebeasi@brandyscarney@sean-perkins@Ionitron