Skip to content

feat(input): add workaround for dynamic slot content - #27636

Merged
liamdebeasi merged 19 commits into
FW-4135from
4135-dynamic
Jun 14, 2023
Merged

feat(input): add workaround for dynamic slot content#27636
liamdebeasi merged 19 commits into
FW-4135from
4135-dynamic

Conversation

@liamdebeasi

@liamdebeasiliamdebeasi commented Jun 12, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue number: N/A

What is the current behavior?

Slotted content added async does not cause the component to re-render.

What is the new behavior?

  • Adding slotted content async causes the component to re-render
  • Changes within the slotted content will also cause the component to re-render so the notch is updated

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz

bolt-new-by-stackblitzBot commented Jun 12, 2023

Copy link
Copy Markdown

Review PR in StackBlitz CodeflowRun & review this pull request in StackBlitz Codeflow.

@github-actionsgithub-actionsBot added the package: core @ionic/core package label Jun 12, 2023
@liamdebeasiliamdebeasi changed the title 4135 dynamicfeat(input): add workaround for dynamic slot contentJun 12, 2023
Base automatically changed from 4135-base to FW-4135June 12, 2023 19:00
@liamdebeasi
liamdebeasi requested review from a team, averyrousseau, brandyscarney and mapsandapps and removed request for a team and mapsandappsJune 13, 2023 15:15
@liamdebeasi

liamdebeasi commented Jun 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Going to keep the same reviewers since they reviewed the previous PRs for this feature

@liamdebeasi
liamdebeasi marked this pull request as ready for review June 13, 2023 15:29
averyrousseau
averyrousseau approved these changes Jun 14, 2023
View reviewed changes
Comment threadcore/src/utils/forms/slot-mutation-controller.ts
brandyscarney
brandyscarney reviewed Jun 14, 2023
View reviewed changes
Comment threadcore/src/components/input/test/slot/index.html
brandyscarney
brandyscarney approved these changes Jun 14, 2023
View reviewed changes

@brandyscarneybrandyscarney left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@liamdebeasiliamdebeasi mentioned this pull request Jun 14, 2023
Merged
2 tasks
@liamdebeasi
liamdebeasi merged commit eb95367 into FW-4135Jun 14, 2023
@liamdebeasi
liamdebeasi deleted the 4135-dynamic branch June 14, 2023 18:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarneybrandyscarneybrandyscarney approved these changes
+1 more reviewer
@averyrousseauaveryrousseauaveryrousseau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core@ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liamdebeasi@brandyscarney@averyrousseau@Ionitron