Skip to content

feat(textarea): add label slot - #27647

Merged
liamdebeasi merged 10 commits into
FW-4409from
4409-base
Jun 15, 2023
Merged

feat(textarea): add label slot#27647
liamdebeasi merged 10 commits into
FW-4409from
4409-base

Conversation

@liamdebeasi

@liamdebeasiliamdebeasi commented Jun 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue number: N/A

What is the current behavior?

Textarea only accepts plaintext labels.

What is the new behavior?

  • Textarea can now accept custom HTML labels via a slot

A few implementation notes:

  • Support for dynamically adding/removing slotted content will be added in a separate PR.
  • Support for the notch outline will be added in a separate PR.
  • The existing start/end placement label overflow tests were made redundant with the new tests I added. As a result, I removed the old tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz

bolt-new-by-stackblitzBot commented Jun 14, 2023

Copy link
Copy Markdown

Review PR in StackBlitz CodeflowRun & review this pull request in StackBlitz Codeflow.

@github-actionsgithub-actionsBot added the package: core @ionic/core package label Jun 14, 2023
@liamdebeasiliamdebeasi changed the title 4409 basefeat(textarea): add label slotJun 14, 2023
liamdebeasi
liamdebeasi commented Jun 14, 2023
View reviewed changes
Comment threadcore/src/components/textarea/textarea.scss
@liamdebeasi
liamdebeasi marked this pull request as ready for review June 14, 2023 16:58
@liamdebeasi
liamdebeasi requested review from a team, brandyscarney and thetaPC and removed request for a teamJune 14, 2023 16:58
@liamdebeasiliamdebeasi mentioned this pull request Jun 14, 2023
Merged
2 tasks
thetaPC
thetaPC approved these changes Jun 14, 2023
View reviewed changes

@thetaPCthetaPC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadcore/src/components/textarea/textarea.tsx
brandyscarney
brandyscarney approved these changes Jun 14, 2023
View reviewed changes

@brandyscarneybrandyscarney left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the notch outline calculation which will be done in a separate PR. 👍

Comment threadcore/src/components/textarea/test/label-placement/textarea.e2e.ts Outdated
Comment threadcore/src/components/textarea/test/label-placement/textarea.e2e.ts Outdated
Comment threadcore/src/components.d.ts Outdated
Comment threadcore/src/components/textarea/textarea.scss
Comment threadcore/src/components/textarea/textarea.tsx Outdated
liamdebeasiand others added 3 commits June 15, 2023 09:01
@liamdebeasi@brandyscarney
Update core/src/components/textarea/test/label-placement/textarea.e2e.ts
6cf3fc1
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi@brandyscarney
Update core/src/components/textarea/test/label-placement/textarea.e2e.ts
8fe23e6
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi
fix experimental docs
de54350
@liamdebeasi
liamdebeasi merged commit 5a35918 into FW-4409Jun 15, 2023
@liamdebeasi
liamdebeasi deleted the 4409-base branch June 15, 2023 17:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPCthetaPCthetaPC approved these changes
@brandyscarneybrandyscarneybrandyscarney approved these changes

Assignees

No one assigned

Labels

package: core@ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liamdebeasi@brandyscarney@thetaPC@Ionitron