Uh oh!
There was an error while loading. Please reload this page.
feat(select): add props to customize toggle icons - #27648
Merged
Conversation
|
Uh oh!
There was an error while loading. Please reload this page.
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Functionality works great. Nice job! Left a thread for discussing the prop names.
Uh oh!
There was an error while loading. Please reload this page.
liamdebeasi
approved these changes
Jun 20, 2023
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Good to go once the CI errors are resolved. Nice work!
sean-perkins
approved these changes
Jun 20, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves#17248
What is the current behavior?
While the
iconshadow part allows customization of the existing toggle icon, developers do not have a way to specify a different icon to use entirely.What is the new behavior?
New props
toggleIconandexpandedIconadded. (Design docs are here and here respectively.)Does this introduce a breaking change?
Other information
Docs PR: ionic-team/ionic-docs#2996
Dev build:
7.0.15-dev.11687278023.161b97d8