Uh oh!
There was an error while loading. Please reload this page.
feat(toast): add shadow part for cancel button - #27921
Conversation
|
liamdebeasi
commented
Aug 3, 2023
Thanks for the PR! We appreciate you contributing to Ionic. I discussed this with the team, and we think this is a good feature to add. Our next step is to do a design document to make sure we are implementing this feature in a way that addresses the original use case. Once that is done, someone from the team will review this PR and get it ready to merge. Let me know if you have any questions. |
liamdebeasi
left a comment
There was a problem hiding this comment.
Overall this looks good! A few small changes.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
liamdebeasi
left a comment
There was a problem hiding this comment.
Can you also rebase this off feature-7.3? This is the next minor release we are targeting.
luisbytes
commented
Aug 9, 2023
Yes, I'll get on it |
luisbytes
commented
Aug 9, 2023
@liamdebeasi Hello, I'm ready with the changes you suggested. I failed to do the rebase. |
liamdebeasi
left a comment
There was a problem hiding this comment.
Great work! I can take care of targeting the feature-7.3 branch.
liamdebeasi
commented
Aug 10, 2023
Merged. Thank you very much! |
luisbytes
commented
Aug 10, 2023
@liamdebeasi Thank you, I hope to contribute more to the community. |
Issue number: resolves#27920
What is the current behavior?
It is not possible to style the buttons with the cancel role in a toast since it uses shadow DOM and there are no exposed parts or CSS variables for the cancel buttons.
What is the new behavior?
button with rol cancelbutton-cancelpart is exposedDoes this introduce a breaking change?
Change the css shadow part for all buttons added to a toast with the cancel role from 'button' to 'button-cancel'.
Other information