Skip to content

fix(many): add correct scale to stacked labels - #28163

Merged
liamdebeasi merged 11 commits into
feature-7.4from
label-stacked-scale
Sep 13, 2023
Merged

fix(many): add correct scale to stacked labels#28163
liamdebeasi merged 11 commits into
feature-7.4from
label-stacked-scale

Conversation

@liamdebeasi

@liamdebeasiliamdebeasi commented Sep 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue number: N/A

What is the current behavior?

The checkbox, radio, range, and toggle stacked labels do not scale which makes them look a bit out of place when used in a list with input/textarea/select stacked labels.

Notice that the stacked Radio label is much larger than the Input label when using the modern syntax. The legacy syntax is consistent where both the Input and Radio stacked labels are scaled.

image

What is the new behavior?

  • Added logic to checkbox, radio, range, and toggle so that the labels scale to 0.75
  • Added the appropriate transform origin for each alignment value
  • Refactored input/textarea/select to use the new global sass variable
  • Added max-width logic to the stacked labels so long labels don't run off the page

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi
liamdebeasi changed the base branch from main to feature-7.4September 13, 2023 13:42
@github-actionsgithub-actionsBot added the package: core @ionic/core package label Sep 13, 2023
@liamdebeasiliamdebeasi changed the title Label stacked scalefix(many): add correct scale to stacked labelsSep 13, 2023
@liamdebeasi
liamdebeasi marked this pull request as ready for review September 13, 2023 15:25
@liamdebeasi
liamdebeasi requested a review from a teamSeptember 13, 2023 15:25
thetaPC
thetaPC approved these changes Sep 13, 2023
View reviewed changes

@thetaPCthetaPC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi
liamdebeasi merged commit 8cb8786 into feature-7.4Sep 13, 2023
@liamdebeasi
liamdebeasi deleted the label-stacked-scale branch September 13, 2023 17:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPCthetaPCthetaPC approved these changes
@brandyscarneybrandyscarneyAwaiting requested review from brandyscarney
@averyrousseauaveryrousseauAwaiting requested review from averyrousseau
+1 more reviewer
@sean-perkinssean-perkinssean-perkins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core@ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liamdebeasi@thetaPC@sean-perkins@Ionitron