Skip to content

refactor(utils): update slotMutationController to allow multiple slot names - #28396

Merged
averyrousseau merged 2 commits into
FW-2853from
FW-2853-base
Nov 27, 2023
Merged

refactor(utils): update slotMutationController to allow multiple slot names#28396
averyrousseau merged 2 commits into
FW-2853from
FW-2853-base

Conversation

@averyrousseau

@averyrousseauaveryrousseau commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Issue number: Internal


What is the current behavior?

The internal slotMutationController utility can only watch one slot name at a time.

What is the new behavior?

Added the option to specify multiple slot names, any of which will trigger the callback. This change is made in preparation for upcoming start and end slots for several form control components; it boosts performance by preventing us from needing to add multiple createSlotMutationController calls to each component.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actionsgithub-actionsBot added the package: core @ionic/core package label Oct 23, 2023
@averyrousseau
averyrousseau marked this pull request as ready for review October 23, 2023 18:18
@averyrousseau
averyrousseau requested review from a team and thetaPC and removed request for a teamOctober 23, 2023 18:41

@thetaPCthetaPC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasiliamdebeasi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but this should be a refactor(util) commit since it's an internal change.

@averyrousseau

Copy link
Copy Markdown
ContributorAuthor

Ah, right, perf will show up in the changelog, huh 🤔 I figured refactor didn't fit since this is a behavior change (if an internal one) but it makes sense if the concern is more public API changes.

@averyrousseauaveryrousseau changed the title perf(utils): update slotMutationController to allow multiple slot namesrefactor(utils): update slotMutationController to allow multiple slot namesOct 25, 2023
@averyrousseau
averyrousseau merged commit bfad5a4 into FW-2853Nov 27, 2023
@averyrousseau
averyrousseau deleted the FW-2853-base branch November 27, 2023 15:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core@ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@averyrousseau@liamdebeasi@thetaPC