Uh oh!
There was an error while loading. Please reload this page.
fix(vue): update output target and properly emit events - #30227
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
christian-bromann
marked this pull request as draft
March 3, 2025 19:49
christian-bromann
marked this pull request as ready for review
March 4, 2025 00:59
christian-bromann
commented
Mar 5, 2025
ContributorAuthor
Verified fix for reproduction case referenced in: #30170 |
christian-bromann
commented
Mar 5, 2025
ContributorAuthor
This does not resolve #30179 |
christian-bromann
commented
Mar 5, 2025
ContributorAuthor
Verified fix for reproduction case referenced in: #30206 |
brandyscarney
approved these changes
Mar 5, 2025
brandyscarney
commented
Mar 5, 2025
Member
Verified the following issues are broken on
|
ShaneK
approved these changes
Mar 5, 2025
ShaneK
left a comment
Member
There was a problem hiding this comment.
I've also tested and verified what Brandy found on 8.4.4-dev.11741193800.14916f6f. Good work! 🚀
2 tasks
andrei0x309
commented
Mar 7, 2025
Can confirm this issue in |
This was referenced Mar 10, 2025
robkorv
commented
Mar 12, 2025
Thanks for the fix! |
This was referenced May 20, 2026
pullBot
pushed a commit
to Zezo-Ai/ionic-framework
that referenced
this pull request
May 20, 2026
…onic-team#31159) Issue number: resolvesionic-team#27843 --------- ## What is the current behavior? `createInlineOverlayComponent` renders inline overlays (modal, popover, etc.) inside a `<template>` at their declared JSX position. When the overlay presents, `CoreDelegate` teleports the DOM node into `ion-app`, but React's synthetic event delegation root stays at the original JSX parent. Once the overlay lives outside that subtree, React no longer dispatches events to children inside it, so `onClick`, `onChange`, and other handlers inside an `IonModal` rendered within an `IonNav` silently stop firing ## What is the new behavior? Top-level inline overlays now render through `createPortal` into the same `ion-app` container that `CoreDelegate` teleports into, so React's event root follows the DOM ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information This issue also reports the same problem in Vue, but that was fixed in ionic-team#30227 Preview: [navigation-modal](https://ionic-framework-git-fw-6314-ionic1.vercel.app/react/navigation-modal) Dev build: ``` 8.8.8-dev.11779302602.17decfbf ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves#30206resolves#30178resolves#30177resolves#30175resolves#30170
What is the current behavior?
There have been plenty of issues reported in regards to Vue components failing to propagate events. It seems like when we updated the Vue output target and started to use the provided runtime code from the output target, we have changed the way how event names are computed. Ionic has used a custom wrapper for handling events that would kebab case event names. That is no longer needed and removing it fixes observed issues.
Reproduction case working: https://stackblitz.com/edit/vj18czas-wdhzxjom?file=package.json
What is the new behavior?
We have received a fix for this in stenciljs/output-targets#617 which I hope will resolve this issue by updating the dependency.
Does this introduce a breaking change?
Other information
Dev build:
8.4.4-dev.11741193800.14916f6f