Uh oh!
There was an error while loading. Please reload this page.
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| await menu.open(); | ||
| } | ||
| async function showPicker() { |
There was a problem hiding this comment.
This was not replaced by ion-picker because that component doesn't apply safe area padding.
| await expect(page.locator('ion-loading')).toBeVisible(); | ||
| }); | ||
| test('should open a picker', async ({ page }) => { |
There was a problem hiding this comment.
The point of this test was to verify the overlay was working as intended so we don't need to migrate it over to use ion-picker.
| await expect(page.locator('ion-modal app-dialog-content')).toBeVisible(); | ||
| }); | ||
| test('should present a picker', async ({ page }) => { |
There was a problem hiding this comment.
The point of this test was to verify the overlay was working as intended so we don't need to migrate it over to use ion-picker.
There was a problem hiding this comment.
The point of this test was to verify the overlay was working as intended so we don't need to migrate it over to use ion-picker.
There was a problem hiding this comment.
The point of this test was to verify the overlay was working as intended so we don't need to migrate it over to use ion-picker.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me! Though I had one comment on the docs version of this that might require changes here should you choose to
Uh oh!
There was an error while loading. Please reload this page.
Issue number: internal
What is the current behavior?
ion-picker-legacyandion-picker-legacy-columnare still available. They are components that have been deprecated in v8.What is the new behavior?
ion-picker-legacyandion-picker-legacy-columnfrom core for v9.ion-picker-legacyandion-picker-legacy-columnfrom the frameworks for v9.Does this introduce a breaking change?
ion-picker-legacyandion-picker-legacy-columnhave been removed. The legacy picker component has been replaced with a inline picker component.ion-picker-legacyorIonPickerLegacyshould be changed toion-pickerandIonPicker, respectively.Other information
N/A