Uh oh!
There was an error while loading. Please reload this page.
feat(angular): make standalone imports default - #31217
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
left a comment
There was a problem hiding this comment.
Awesome work! Just a few problems below, but I also noticed a couple of other problems outside the diff scope:
- BREAKING.md wasn't updated, and it definitely should be for this. This is a massive breaking change. Worth a migration note: @ionic/angular/standalone becomes @ionic/angular, and @ionic/angular becomes @ionic/angular/lazy. The existing Module Resolution section also uses @ionic/angular/standalone as its example subpath (BREAKING.md:203), which no longer exists after this change.
- The Project Structure section in packages/angular/README.md (lines 96-114) is now stale. It still describes a src submodule imported from @ionic/angular and standalone imported from @ionic/angular/standalone, both reversed and renamed now.
Uh oh!
There was an error while loading. Please reload this page.
ShaneK
left a comment
There was a problem hiding this comment.
Awesome! Thanks! Two minor doc change requests, but not blocking
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
What is the current behavior?
The default path for imports is
@ionic/angularand imports the lazy-loaded angular components.@ionic/angular/standaloneimports the standalone components.What is the new behavior?
The default path,
@ionic/angular, imports standalone components. Lazy-loaded components are imported from@ionic/angular/lazy.Does this introduce a breaking change?
Applications that use lazy-loaded angular components will need to update their import paths from
@ionic/angularto@ionic/angular/lazy.Applications that use standalone angular components will need to update their import paths from
@ionic/angular/standaloneto@ionic/angular.Other information
Ionic starters will need their import paths updated to match these changes.