Skip to content

Add isArrayOfTrytes method in ValidatorUtil class - #70

Open
peter279k wants to merge 1 commit into
iota-php:masterfrom
peter279k:isArrayOfTrytes
Open

Add isArrayOfTrytes method in ValidatorUtil class#70
peter279k wants to merge 1 commit into
iota-php:masterfrom
peter279k:isArrayOfTrytes

Conversation

@peter279k

@peter279kpeter279k commented Sep 26, 2018

Copy link
Copy Markdown
Contributor

@peter279k

Copy link
Copy Markdown
ContributorAuthor

@Techworker, please review this PR. Thanks.

@TechworkerTechworker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why you added the 2673 as a required length. The method is called isArrayOfTrytes and a trytestring does not necessarily need to be 2673 trytes long.

@peter279k

Copy link
Copy Markdown
ContributorAuthor

Hi @Techworker, thank you for your reply.
I refer this line and I found that this should check the trytes is 2673.

Is this unnecessary? Thanks.

@Techworker

Copy link
Copy Markdown
Member

I think its unnecessary

@peter279k

Copy link
Copy Markdown
ContributorAuthor

Hi @Techworker, thank you for your reply. Do you mean I remove this 2673, and using the default value?

It makes sense I think. I will try that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants

@peter279k@Techworker