Uh oh!
There was an error while loading. Please reload this page.
docs: Clarify on README now to run tests - #236
Conversation
…le-pubsub-experiment` & and without `--mount`
vorburger
commented
Feb 28, 2025
|
vorburger
commented
Feb 28, 2025
Re. #237 and this, I've noticed that It does not seem to help with those test failures, so I doubt that it's required. |
| ### Running tests | ||
| To run tests, IPFS daemon must be running on `127.0.0.1` interface. | ||
| To run tests, IPFS daemon must be running on `127.0.0.1` interface, with `--enable-pubsub-experiment`, and without `--mount`. |
There was a problem hiding this comment.
The --mount is not the default, so why mention it?
There was a problem hiding this comment.
@cstamas I've no idea anymore why I wrote this, a year ago! I've removed it. (Squash and) merge as-is?
Removed the requirement for the IPFS daemon to run without `--mount` when running tests, based on PR code review feedback.
There was a problem hiding this comment.
Pull request overview
This PR updates the README documentation to clarify the requirements for running tests. Specifically, it adds the requirement that the IPFS daemon must be run with the --enable-pubsub-experiment flag.
Changes:
- Added
--enable-pubsub-experimentflag requirement to the "Running tests" section
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Kubo must run with
--enable-pubsub-experiment& and without.--mount@ianopolous merge?