Skip to content
This repository was archived by the owner on Aug 17, 2020. It is now read-only.

switch to persistent peerstore - #19

Open
raulk wants to merge 6 commits into
masterfrom
feat/pstoreds
Open

switch to persistent peerstore#19
raulk wants to merge 6 commits into
masterfrom
feat/pstoreds

Conversation

@raulk

@raulkraulk commented Jul 2, 2019

Copy link
Copy Markdown
Member

Perhaps this helps:

[NumDhts: 40, Uptime: 5m0s, Memory Usage: 57 MB, TotalPeers: 737/1213, Total Provs: 0, BootstrapsDone: 3]
[NumDhts: 40, Uptime: 5m5s, Memory Usage: 67 MB, TotalPeers: 736/1225, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m10s, Memory Usage: 77 MB, TotalPeers: 751/1239, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m15s, Memory Usage: 82 MB, TotalPeers: 745/1251, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m20s, Memory Usage: 87 MB, TotalPeers: 729/1260, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m25s, Memory Usage: 90 MB, TotalPeers: 707/1267, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m30s, Memory Usage: 50 MB, TotalPeers: 706/1280, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m35s, Memory Usage: 54 MB, TotalPeers: 681/1285, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m40s, Memory Usage: 58 MB, TotalPeers: 663/1290, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m45s, Memory Usage: 62 MB, TotalPeers: 646/1299, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m50s, Memory Usage: 67 MB, TotalPeers: 639/1309, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m55s, Memory Usage: 71 MB, TotalPeers: 633/1322, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 6m0s, Memory Usage: 77 MB, TotalPeers: 616/1333, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 6m5s, Memory Usage: 81 MB, TotalPeers: 602/1335, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 6m10s, Memory Usage: 84 MB, TotalPeers: 583/1342, Total Provs: 0, BootstrapsDone: 32]

@raulk
raulk requested review from Kubuxu and whyrusleepingJuly 2, 2019 13:37
raulkand others added 2 commits July 2, 2019 15:43
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
To remove bad badger
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxuand others added 2 commits July 2, 2019 23:39
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Comment threadmain.go Outdated
}

opts := pstoreds.DefaultOpts()
opts.CacheSize = 0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this increase our allocation velocity?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but in a shared setup, the cache is useless because it'll just be thrashing all the time.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on size and type of cache.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have metrics regarding the hit rate. Unfortunately, open census was disabled because it was allocating too much (Why knows more).

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@raulk@Kubuxu