Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 8, 2026. It is now read-only.
rust: add type aliases for Address, Bytes32, Uint256 - #343
Merged
Conversation
axic
commented
Jul 3, 2019
Uh oh!
There was an error while loading. Please reload this page.
axic
commented
Jul 3, 2019
MemberAuthor
Need to squash this prior to merge. |
axicforce-pushed
the
rust-types
branch
3 times, most recently
from
July 4, 2019 18:29
ba8a74e to
d29218fComparejakelang
reviewed
Jul 5, 2019
jakelang
left a comment
Contributor
There was a problem hiding this comment.
I prefer newtype notation, i.e. struct Address(ffi::evmc_address) as it is cleaner than implementing methods for types that have been declared by bindgen. This is ok though.
axic
commented
Jul 5, 2019
MemberAuthor
That was original version, but that requires from traits for conversion, IIRC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #319.
Enums are handled in #206.