Uh oh!
There was an error while loading. Please reload this page.
Misc type annotations - #1294
Merged
Merged
Conversation
Extracted from ipython#1272
minrk
reviewed
Nov 14, 2024
| control_thread = Any() | ||
| shell_channel_thread = Any() | ||
| iopub_thread: BaseThread |
Member
There was a problem hiding this comment.
I think these still need to be defined as traits, e.g. : BaseThread = Any() or perhaps even Instance(BaseThread, allow_none=True).
MemberAuthor
There was a problem hiding this comment.
I think that will need a # type: ignore[assignment] as well, or mypy will be unhappy
Carreau
commented
Nov 14, 2024
MemberAuthor
Updated, and fixed the corresponding error shown by mypy. |
minrk
commented
Nov 15, 2024
Member
Thanks! |
Carreau
commented
Nov 15, 2024
MemberAuthor
thanks for the review and merge ! |
ianthomas23 pushed a commit
to ianthomas23/ipykernel
that referenced
this pull request
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #1272