Uh oh!
There was an error while loading. Please reload this page.
make debugger class configurable - #1307
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jasongrout
left a comment
There was a problem hiding this comment.
Awesome, thanks! In full disclosure, we'd like this at Databricks (where Stephen and I both work) because we customize the debugger class.
krassowski
left a comment
There was a problem hiding this comment.
It seems fine, but not 100% sure as I get an error when trying to install kernel: #1309
jasongrout
commented
Dec 16, 2024
Carreau
commented
Feb 11, 2025
Can this get rebased to trigger CI (I try to do it, but there is no allow push from maintainers). |
6bd5782 to
175f1dcComparefor more information, see https://pre-commit.ci
smacke
commented
Feb 11, 2025
Hey @Carreau just rebased + pushed |
Carreau
commented
Feb 12, 2025
There is one minor lint to fix (unused mypy ignore), and I restarted the test on 3.9. I would actually be in favor of dropping 3.9 support (per https://scientific-python.org/specs/spec-0000/), and FYI IPython CLI already dropped 3.10. |
smacke
commented
Feb 14, 2025
@Carreau did you want me to fix those lint failures? They don't seem related with this change but happy to do it anyway |
Carreau
commented
Feb 14, 2025
No, it was just a "the failures are know and fixed on master". I haven't been involved in ipykernel in a while and was reluctant to merge, but I think that's ok. |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
In this PR, add fields
compiler_classanddebugger_classdefaulting to the normal types. Kernel subclasses can override these to provide additional customizations.