Skip to content

make debugger class configurable - #1307

Merged
Carreau merged 4 commits into
ipython:mainfrom
smacke:smacke/configurable-debugger
Feb 14, 2025
Merged

make debugger class configurable#1307
Carreau merged 4 commits into
ipython:mainfrom
smacke:smacke/configurable-debugger

Conversation

@smacke

@smackesmacke commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

In this PR, add fields compiler_class and debugger_class defaulting to the normal types. Kernel subclasses can override these to provide additional customizations.

Comment threadipykernel/ipkernel.py
Comment threadipykernel/ipkernel.py Outdated

@jasongroutjasongrout left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! In full disclosure, we'd like this at Databricks (where Stephen and I both work) because we customize the debugger class.

@krassowskikrassowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine, but not 100% sure as I get an error when trying to install kernel: #1309

@jasongrout

Copy link
Copy Markdown
Member

It seems fine, but not 100% sure as I get an error when trying to install kernel: #1309

Following up here for completeness, it seems like David fixes this error in #1310

@Carreau

Copy link
Copy Markdown
Member

Can this get rebased to trigger CI (I try to do it, but there is no allow push from maintainers).

@smacke
smackeforce-pushed the smacke/configurable-debugger branch from 6bd5782 to 175f1dcCompareFebruary 11, 2025 23:33
@smacke

Copy link
Copy Markdown
ContributorAuthor

Hey @Carreau just rebased + pushed

@Carreau

Copy link
Copy Markdown
Member

There is one minor lint to fix (unused mypy ignore), and I restarted the test on 3.9.

I would actually be in favor of dropping 3.9 support (per https://scientific-python.org/specs/spec-0000/), and FYI IPython CLI already dropped 3.10.

@smacke

Copy link
Copy Markdown
ContributorAuthor

@Carreau did you want me to fix those lint failures? They don't seem related with this change but happy to do it anyway

@Carreau

Copy link
Copy Markdown
Member

No, it was just a "the failures are know and fixed on master". I haven't been involved in ipykernel in a while and was reluctant to merge, but I think that's ok.

@Carreau
Carreau merged commit 3867c33 into ipython:mainFeb 14, 2025
@CarreauCarreau added this to the 7.0 milestone Feb 23, 2025
ianthomas23 pushed a commit to ianthomas23/ipykernel that referenced this pull request Jul 14, 2025
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@smacke@jasongrout@Carreau@davidbrochart@krassowski