Skip to content

Delete always skipped test, fix trio test, fix framelocal has not .clear() - #1322

Merged
Carreau merged 7 commits into
ipython:mainfrom
Carreau:del-always-skip
Feb 19, 2025
Merged

Delete always skipped test, fix trio test, fix framelocal has not .clear()#1322
Carreau merged 7 commits into
ipython:mainfrom
Carreau:del-always-skip

Conversation

@Carreau

@CarreauCarreau commented Feb 12, 2025

Copy link
Copy Markdown
Member

There are few chances we will ever use them again.

Also a small refactor and unskip of trio test using trio nursery.

@Carreau
Carreauforce-pushed the del-always-skip branch 2 times, most recently from da04e6e to 48caeaaCompareFebruary 12, 2025 18:38
@CarreauCarreau changed the title Delete always skipped tests that used removed attributes.Delete always skipped tests that used removed attributes, and unskip trio testFeb 12, 2025
@Carreau

Carreau commented Feb 12, 2025

Copy link
Copy Markdown
MemberAuthor

Well that's strange, trio test passes locally...

well on CI, anyio decides to switch in the middle of the call stack from trio to asyncio:

 | tg.start_soon(self.kernel.start)
| File ".../site-packages/anyio/_backends/_trio.py", line 191, in __aexit__
| return await self._nursery_manager.__aexit__(exc_type, exc_val, exc_tb) # type: ignore[return-value]
| File ".../site-packages/trio/_core/_run.py", line 1043, in __aexit__
| raise combined_error_from_nursery
| exceptiongroup.ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
+-+---------------- 1 ----------------
| Traceback (most recent call last):
| File ".../ipykernel/ipykernel/kernelapp.py", line 753, in _wait_to_enter_eventloop
| await self.kernel._eventloop_set.wait()
| File ".../site-packages/anyio/_core/_synchronization.py", line 139, in wait
| await self._event.wait()
| File ".../site-packages/anyio/_backends/_asyncio.py", line 1764, in wait
| await AsyncIOBackend.checkpoint()
| File ".../site-packages/anyio/_backends/_asyncio.py", 

@Carreau

Copy link
Copy Markdown
MemberAuthor

Well something else is wrong on CI, some pytest items are failing, but it's shown as green on 3.10: https://github.com/ipython/ipykernel/actions/runs/13292836924/job/37117594041?pr=1322

Comment threadtests/test_kernelapp.py
@davidbrochart

Copy link
Copy Markdown
Collaborator

Well something else is wrong on CI, some pytest items are failing, but it's shown as green on 3.10: https://github.com/ipython/ipykernel/actions/runs/13292836924/job/37117594041?pr=1322

It's because we rerun last failed tests here.

@Carreau
Carreauforce-pushed the del-always-skip branch 3 times, most recently from acec02b to 6dd8fedCompareFebruary 13, 2025 12:48
@CarreauCarreau changed the title Delete always skipped tests that used removed attributes, and unskip trio testDelete always skipped test, fix trio test, fix framelocal has not .clear()Feb 19, 2025
@Carreau

Carreau commented Feb 19, 2025

Copy link
Copy Markdown
MemberAuthor

fix framelocal has not .clear()

It would be really great to get that merged, as this fixes failures of other PRs

Comment threadpyproject.toml Outdated
Comment threadpyproject.toml Outdated
Carreauand others added 2 commits February 19, 2025 09:52
Co-authored-by: David Brochart <david.brochart@gmail.com>
@Carreau

Copy link
Copy Markdown
MemberAuthor

(docs breckage is due to new sphinx release and unrelated to us)

Comment threadipykernel/kernelapp.py

@krassowskikrassowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The sphinx issue is tracked in tox-dev/sphinx-autodoc-typehints#523

Comment threadipykernel/kernelapp.py
@Carreau

Copy link
Copy Markdown
MemberAuthor

Thanks for the reviews. Merging.

@Carreau
Carreau merged commit 28d096d into ipython:mainFeb 19, 2025
@CarreauCarreau added this to the 7.0 milestone Feb 23, 2025
ianthomas23 added a commit to ianthomas23/ipykernel that referenced this pull request Apr 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Carreau@davidbrochart@krassowski