Uh oh!
There was an error while loading. Please reload this page.
Bump mypy - #1333
Merged
Merged
Conversation
Carreau
commented
Feb 13, 2025
MemberAuthor
Everything (except downstream as usual) is passing. |
Carreauforce-pushed
the
bump-mypy
branch
5 times, most recently
from
February 17, 2025 19:12
0ff1284 to
253e82bComparekrassowski
approved these changes
Feb 19, 2025
Uh oh!
There was an error while loading. Please reload this page.
| await self._dispatch_to_kernel(msg) | ||
| return msg["header"]["msg_id"] | ||
| res = msg["header"]["msg_id"] | ||
| assert isinstance(res, str) |
Member
There was a problem hiding this comment.
I wondered if typing.cast could be safer, but per protocol it looks like a valid assertion
MemberAuthor
There was a problem hiding this comment.
I agree, my hope is that if it's wrong we can at least trigger failures with nightlies/pre-release, whcih a cat would not
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Carreau
commented
Feb 19, 2025
| await self._dispatch_to_kernel(msg) | ||
| return msg["header"]["msg_id"] | ||
| res = msg["header"]["msg_id"] | ||
| assert isinstance(res, str) |
MemberAuthor
There was a problem hiding this comment.
I agree, my hope is that if it's wrong we can at least trigger failures with nightlies/pre-release, whcih a cat would not
Carreau
commented
Feb 19, 2025
MemberAuthor
docs failure unrelated. |
ianthomas23 pushed a commit
to ianthomas23/ipykernel
that referenced
this pull request
Apr 10, 2025
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.