Uh oh!
There was an error while loading. Please reload this page.
Make our own mock kernel methods async - #1346
Merged
Merged
Conversation
As we are recommending upstream to use asyn, mught as well do it ourselves a well. Plus this makes sure our test suite tests async
minrk
approved these changes
Feb 19, 2025
krassowski
commented
Feb 19, 2025
Member
I think there is a typo in the title, should be |
Carreau
commented
Feb 19, 2025
MemberAuthor
Oops ! Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are recommending upstream to use asyn, mught as well do it ourselves a well.
Plus this makes sure our test suite tests async