Skip to content

[535] Implement basic support for GenQuery2 - #555

Merged
alanking merged 1 commit into
irods:mainfrom
stsnel:add-basic-genquery2-support
May 17, 2024
Merged

[535] Implement basic support for GenQuery2#555
alanking merged 1 commit into
irods:mainfrom
stsnel:add-basic-genquery2-support

Conversation

@stsnel

Copy link
Copy Markdown
Collaborator

Here's a draft for an initial version of GenQuery2 support (issue 535)

@stsnel
stsnelforce-pushed the add-basic-genquery2-support branch from ff51694 to 352ef9cCompareMay 13, 2024 11:29
@korydraughn

Copy link
Copy Markdown
Contributor

Thanks for the contribution. We'll review and share our thoughts.

@alankingalanking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few suggestions/comments. I would have suggested adding more tests, but the existing tests basically exercise the interface in this client, so I don't think it would add anything beyond just testing the API (which we do plenty of in the main repo).

Nice work!

Comment threadirods/query2.py Outdated
Comment threadirods/query2.py Outdated
Comment threadirods/query2.py Outdated
Comment threadirods/session.py Outdated
Comment threadirods/test/query2_test.py Outdated
Comment threadirods/test/query2_test.py Outdated
@stsnel
stsnelforce-pushed the add-basic-genquery2-support branch from 352ef9c to e239307CompareMay 14, 2024 19:03
@stsnel

Copy link
Copy Markdown
CollaboratorAuthor

I had a few suggestions/comments. I would have suggested adding more tests, but the existing tests basically exercise the interface in this client, so I don't think it would add anything beyond just testing the API (which we do plenty of in the main repo).

Nice work!

Thank you for the feedback!

Comment threadirods/genquery2.py Outdated
Comment threadirods/genquery2.py
Comment threadirods/genquery2.py Outdated
Comment threadREADME.md Outdated
@stsnel
stsnelforce-pushed the add-basic-genquery2-support branch 3 times, most recently from dac3a60 to cb8230dCompareMay 16, 2024 14:18

@korydraughnkorydraughn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Let's get an approval from @alanking and @d-w-moore before adding the pound.

@alankingalanking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's make sure @d-w-moore is okay with it and I think we'll be good to go.

@d-w-moored-w-moore left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@stsnel
stsnelforce-pushed the add-basic-genquery2-support branch from cb8230d to 6b67b98CompareMay 17, 2024 05:46
@alanking
alanking merged commit 71d787f into irods:mainMay 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@stsnel@korydraughn@alanking@d-w-moore