Uh oh!
There was an error while loading. Please reload this page.
[535] Implement basic support for GenQuery2 - #555
Conversation
ff51694 to
352ef9cComparekorydraughn
commented
May 13, 2024
Thanks for the contribution. We'll review and share our thoughts. |
alanking
left a comment
There was a problem hiding this comment.
I had a few suggestions/comments. I would have suggested adding more tests, but the existing tests basically exercise the interface in this client, so I don't think it would add anything beyond just testing the API (which we do plenty of in the main repo).
Nice work!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
352ef9c to
e239307Comparestsnel
commented
May 14, 2024
Thank you for the feedback! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dac3a60 to
cb8230dCompare
korydraughn
left a comment
There was a problem hiding this comment.
Looks good to me.
Let's get an approval from @alanking and @d-w-moore before adding the pound.
alanking
left a comment
There was a problem hiding this comment.
Yes, let's make sure @d-w-moore is okay with it and I think we'll be good to go.
cb8230d to
6b67b98Compare
Here's a draft for an initial version of GenQuery2 support (issue 535)