Skip to content

[#517] allow generating a pam-password based .irodsA if not pre-existing - #620

Merged
alanking merged 1 commit into
irods:mainfrom
d-w-moore:517.m
Oct 11, 2024
Merged

[#517] allow generating a pam-password based .irodsA if not pre-existing#620
alanking merged 1 commit into
irods:mainfrom
d-w-moore:517.m

Conversation

@d-w-moore

@d-w-moored-w-moore commented Sep 18, 2024

Copy link
Copy Markdown
Collaborator

Capability for PRC to generate a PAM-based .irodsA authentication file, as iinit does when pam_password is the authentication scheme.

@d-w-moore
d-w-moore marked this pull request as draft September 18, 2024 09:09
This was referenced Sep 18, 2024
Closed
Closed
trel
trel reviewed Sep 19, 2024
View reviewed changes
Comment threadirods/client_init.py Outdated
trel
trel reviewed Sep 24, 2024
View reviewed changes
Comment threadirods/__init__.py
@korydraughn

korydraughn commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

Will review once PR is out of draft.

@d-w-moore
d-w-moore marked this pull request as ready for review September 26, 2024 16:20
korydraughn
korydraughn reviewed Oct 1, 2024
View reviewed changes
Comment threadirods/test/scripts/test002.bats Outdated
Comment threadirods/test/scripts/test002.bats Outdated
Comment threadirods/test/scripts/test002.bats
Comment threadirods/test/scripts/test002.bats Outdated
Comment threadirods/test/scripts/test002.bats Outdated
Comment threadirods/test/scripts/test003.bats Outdated
@korydraughn

korydraughn commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

Seems I was missing part of the commit during the review.

Looking at other (modified) files now.

@d-w-moore

d-w-moore commented Oct 1, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Seems I was missing part of the commit during the review.

Looking at other (modified) files now.

Wondering if you were referring to the docker test implementation itself, which has been put off to a 3.0+ milestone. If this is confusing, I could defer inclusion of the actual tests to a later pull request.

korydraughn
korydraughn reviewed Oct 1, 2024
View reviewed changes
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadirods/client_init.py Outdated
@korydraughn

korydraughn commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

Wondering if you were referring to the docker test implementation itself, which has been put off to a 3.0+ milestone. If this is confusing, I could defer inclusion of the actual tests to a later pull request.

I think the GitHub notification only showed me the latest changes and I failed to think about changes that could have been made prior to that.

It's fine, I've looked at the other files and left comments.

alanking
alanking reviewed Oct 1, 2024
View reviewed changes

@alankingalanking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very helpful for theoretical and non-theoretical future projects :)

Comment threadirods/__init__.py
Comment threadirods/session.py
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadirods/client_init.py Outdated
Comment threadirods/__init__.py Outdated
Comment threadREADME.md
@alanking

alanking commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

Please resolve review conversations as things are addressed, if appropriate. Also, take a peek at some of those Codacy issues and see if there's anything in need of addressing in your view. Thanks

@d-w-moore

d-w-moore commented Oct 7, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Please resolve review conversations as things are addressed, if appropriate. Also, take a peek at some of those Codacy issues and see if there's anything in need of addressing in your view. Thanks

Yes, will do

alanking
alanking reviewed Oct 10, 2024
View reviewed changes

@alankingalanking left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I think it's ready for squashing, but let's wait for one more vote before doing so just in case there are other review comments.

Oh, and unresolved conversations. Forgot about that.

@d-w-moore

d-w-moore commented Oct 10, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Seems fine to me. I think it's ready for squashing, but let's wait for one more vote before doing so just in case there are other review comments.

Oh, and unresolved conversations. Forgot about that.

Still working on the conversations and final testing, so don't worry. No rush.

trel
trel reviewed Oct 10, 2024
View reviewed changes
Comment threadREADME.md Outdated
alanking
alanking reviewed Oct 11, 2024
View reviewed changes

@alankingalanking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me. No open conversations, I think. Please await thoughts from others before The Squash

korydraughn
korydraughn reviewed Oct 11, 2024
View reviewed changes
Comment threadREADME.md Outdated
@korydraughn

korydraughn commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Please squash.

korydraughn
korydraughn approved these changes Oct 11, 2024
View reviewed changes

@korydraughnkorydraughn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@d-w-moore
[irods#517,irods#596,irods#621] generate .irodsA for pam_password and…
55b2da9
… native authentication.
This commit introduces iinit-like capability to generate the .irodsA file, when not
previously existing, for the pam_password authentication scheme. Also, free functions
are introduced which create the .irodsA file from a cleartext password value in the native and
pam_password authentication schemes.
@alanking
alanking merged commit dcd6c13 into irods:mainOct 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@treltreltrel left review comments
@korydraughnkorydraughnkorydraughn approved these changes
+1 more reviewer
@alankingalankingalanking left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@d-w-moore@korydraughn@alanking@trel