Skip to content

Multiple framework and Crop rectangle - #1

Merged
mee-ironsoftware merged 10 commits into
mainfrom
multiple-framework-croprectangle
Jun 28, 2022
Merged

Multiple framework and Crop rectangle#1
mee-ironsoftware merged 10 commits into
mainfrom
multiple-framework-croprectangle

Conversation

@mee-ironsoftware

@mee-ironsoftwaremee-ironsoftware commented Jun 14, 2022•
edited
Loading

Copy link
Copy Markdown
Member
  • Add .NET 4.5 for .NET Framework
  • Change SkiaSharp from 2.80.0 to 1.68.1 for supported .NET 4.5
  • Add Class CropRectangle

@jacob-mellor

jacob-mellor commented Jun 14, 2022

Copy link
Copy Markdown
Member

i suggest that framework version uses old SKiaSharp. WE should use latest.
#if FRAMEWORK

@jacob-mellor

jacob-mellor commented Jun 14, 2022

Copy link
Copy Markdown
Member

Later work repo should have some basic unit tests

  • .NET CORE 2,3,5,6,7 multitargets + Framework 4.5

xUnitProjects

  • Skia.Oldest
  • Skia.Latest
  • System.Drawing.Common.Oldest
  • System.Drawing.Common.Newest
  • Maui.Oldest
  • Maui.Newest
  • No frameworks installed at all !

mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/CropRectangle.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/CropRectangle.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/CropRectangle.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/IronBitmap.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/Color.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/Color.cs Outdated
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/Color.cs
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/Color.cs Outdated
mbkrispy
mbkrispy approved these changes Jun 28, 2022
View reviewed changes

@mbkrispymbkrispy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added my comments to changes I would make and questions!

@mee-ironsoftware
mee-ironsoftware merged commit 92abd63 into mainJun 28, 2022
mbkrispy
mbkrispy reviewed Jun 28, 2022
View reviewed changes
Comment threadIronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs
/// <param name="Format">An image encoding format.</param>
/// <param name="Lossy">Jped and WebP encoding quality (ignored for all other values of <see cref="ImageFormat"/>). Higher values return larger file sizes. 0 is lowest quality , 100 is highest.</param>
/// <returns>Transcoded image bytes.[</returns>
/// <param name="Lossy">Jped and WebP encoding quality (ignored for all other values of <see cref="ImageFormat"/>). Higher values return larger file sizes. 0 is lowest quality , 100 is highest.</param>

@mbkrispymbkrispyJun 28, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just saw this. Jped => Jpeg

@artemkoloskov-admin
artemkoloskov-admin deleted the multiple-framework-croprectangle branch March 28, 2023 02:49
@mee-ironsoftwaremee-ironsoftware mentioned this pull request Jul 17, 2026
Merged
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacob-mellorjacob-mellorAwaiting requested review from jacob-mellor
1 more reviewer
@mbkrispymbkrispymbkrispy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mee-ironsoftware@jacob-mellor@mbkrispy