Uh oh!
There was an error while loading. Please reload this page.
Add action to test kustomize config validity - #419
Merged
Conversation
They were rendering as spaces in the action output
ACLay
commented
Aug 26, 2026
Comment on lines
+34
to
+37
| if [ "$?" -ne "0" ]; then | ||
| echo "Verification error in $devOverlay" | ||
| ! break | ||
| fi |
ContributorAuthor
There was a problem hiding this comment.
There seems to be some variability in how shells handle errors in loops. Locally, this if statement was needed to catch the non-zero exit code from a failed kubectl apply ... and force the loop to exit with an error, but the action itself just exits on the failed kubectl apply .... Keeping this check here means the code can still be used locally, and we're covered incase the action's environment changes.
William-Edwards-STFC
approved these changes
Aug 26, 2026
deepaksftc
approved these changes
Aug 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #408
Mirror's the config repo's jenkins job to dry-run apply our kubernetes config and catch any syntax errors before they make it into the main branch. I've set the kubeconfigs up as repo secrets for now. Will look at moving them to organisation ones once I'm confident everything's set up properly.
Examples of failed and successful runs can be seen in the last few commits, after I worked out the bugs in the action.