Uh oh!
There was an error while loading. Please reload this page.
Move fap booklet generator to gitops - #423
Open
William-Edwards-STFC wants to merge 4 commits into
Open
Conversation
ACLay
reviewed
Aug 27, 2026
| name: common-pug-views-2026 | ||
| - name: common-public | ||
| configMap: | ||
| name: common-pug-public-2026 |
Contributor
There was a problem hiding this comment.
I'm guessing all this config is from the booklet generator's develop branch. These volumes aren't used by the prod build yet, which was deployed from master.
Contributor
There was a problem hiding this comment.
I think we'd either need to rework the config's so that the volumes are split, or maybe wait until I've released the changes to fap booklet generator before we add the prod config here.
MemberAuthor
There was a problem hiding this comment.
Ive used the config from master when we release fap booklets we can change the base deployment on the release branch that the workflow makes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/isisbusapps/docker-orchestration/pull/1161
https://github.com/isisbusapps/fap-booklet-generator/pull/337