Uh oh!
There was an error while loading. Please reload this page.
chore: align dev tooling with event-database-imports - #31
Merged
Conversation
Bring the dev-tooling surface in line with the canonical event-database-imports setup (its PR #88 raised PHPStan and added strict rules): - PHPStan level 6 -> 8 with phpstan/phpstan-strict-rules, existing findings baselined (phpstan-baseline.neon) so new code is held to the higher bar. - Exclude the auto-generated config/reference.php; drop tests/ from analysis (matching importers) and use identifier-based ignores. - PHP 8.4 as the committed docker-compose default (dev override already used it). - twig-cs-fixer ^3.7 -> ^4.0 and PHPUnit ^12 -> ^13; php-cs-fixer follows to 3.95 (one else-after-return fix applied). phpstan (level 8), php-cs-fixer, twig-cs-fixer, composer audit, and the API test suite (19 tests) all pass.
✅ No changes detected in API specification |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align this repo's dev-tooling surface with the canonical
event-database-importssetup — its PR #88 raised PHPStan to level 8 with strict rules, and the PHP/tooling versions had drifted apart.Changes
phpstan/phpstan(explicit) andphpstan/phpstan-strict-rules. Existing findings baselined inphpstan-baseline.neon(34 entries) so new code is held to the higher bar. Exclude the auto-generatedconfig/reference.php, droptests/from analysis, and switch to identifier-basedignoreErrors— all matching importers. (Dropped importers' Doctrine/method.unusedignores, which don't apply here.)itkdev/php8.4-fpmas the committeddocker-compose.yml/docker-compose.server.ymldefault (the dev override already used 8.4;composer.jsonstays>=8.3).^3.7→^4.0— config is byte-identical to importers, so v4 lints clean.^12→^13— pullsphp-cs-fixerto 3.95 (matching importers), which applied oneelse-after-returnsimplification inElasticSearchIndex.php.Not aligned (deliberately)
Importers'
doctrine/*,messenger-test,liip/test-fixtures,phpstan-doctrine, and Mate dev deps are specific to its write/admin stack — N/A to this read-only, no-Doctrine API.Verification
All run in the
phpfpmcontainer (PHP 8.4):phpstan analyse(level 8 + strict) → No errorsphp-cs-fixer check→ clean ·twig-cs-fixer lint(v4) → OKcomposer audit --locked→ no advisories ·composer normalize --dry-run→ normalizedbin/phpunit(PHPUnit 13) → 19 tests, 44 assertions, OK