Uh oh!
There was an error while loading. Please reload this page.
Fix api-spec no-change detection for oasdiff v0.1.x - #61
Merged
Conversation
The changelog step's "spec changed?" guard grepped for the literal "no changes", but oasdiff v0.1.x emits "No changelog changes" when the spec is unchanged — the substring never matched, so has_changes was always true and a "⚠️ non-breaking changes" comment posted (body: "No changelog changes") even for PRs that don't touch the spec (e.g. the Elasticsearch bump #60). Match both wordings with a regex so the no-change path is taken and the sticky comment resolves to ✅.
turegjorupforce-pushed
the
ci/api-spec-no-change-detection
branch
from
July 9, 2026 09:00
3f3b30b to
4e3dcfcCompareUh oh!
There was an error while loading. Please reload this page.
codecov-commenter
commented
Jul 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## develop #61 +/- ##
==========================================
Coverage 72.89% 72.89% Complexity 232 232 ==========================================
Files 29 29 Lines 653 653 ==========================================
Hits 476 476 Misses 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the misleading "⚠️ API specification — non-breaking changes" comment on PRs that don't touch the spec (e.g. #60, the Elasticsearch bump — the comment body literally read "No changelog changes").
Root cause
The
detect-breaking-changesjob's "Determine whether the spec changed" step:oasdiff v0.1.x (adopted in #49) emits "No changelog changes" for an unchanged spec. The grep looks for the substring⚠️ comment fired with an empty/no-change body. (The pre-v0.1 wording was "No changes", which matched — so this regressed with the version bump, undetected until a no-spec-change PR ran.)
no changes, which doesn't occur in "No changelog changes", sohas_changeswas alwaystrue→ theFix
Match both wordings:
grep -qiE 'no (changelog )?changes'. Verified it flags "No changelog changes" and "No changes" as no-change, while a real changelog (e.g.### GET /api/v2/events\n- added …) still counts as a change.With this, a no-spec-change PR takes the no-change path: the⚠️ comment no longer posts, and any prior comment self-heals to ✅ (via #55's resolve step).