Uh oh!
There was an error while loading. Please reload this page.
#582: Fix Markdown importer dropping items after a code block following a title - #583
Merged
redcatbear merged 3 commits intoSep 5, 2026
Conversation
… following a title The TITLE parser state had no transition for an opening code fence, so the fence fell through to EVERYTHING and the closing fence then opened a phantom code block that swallowed the rest of the file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Hgw7DCVCJ6hEmxYz5cU8K
koppor
commented
Aug 31, 2026
ContributorAuthor
Fix seems to be straight-forward. Would really help us while using OFT. |
redcatbear
requested changes
Sep 4, 2026
redcatbear
left a comment
Collaborator
There was a problem hiding this comment.
Please add a second requirement to the unit test.
| A --> B | ||
| ``` | ||
| `req~example~1` |
Collaborator
There was a problem hiding this comment.
I think adding a second requirement for safety here would be good to prove that the next ones are not dropped.
ContributorAuthor
There was a problem hiding this comment.
Added req~example~2 right after — the test now asserts both items are detected.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JLNaSxsDCZE4mi4yAwVfzQ
redcatbear
approved these changes
Sep 5, 2026
| A --> B | ||
| ``` | ||
| `req~example~1` |
redcatbear
commented
Sep 5, 2026
Collaborator
Thank you @koppor for contributing this bug fix. Very much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#582: a fenced code block whose opening fence directly follows a section title made the importer silently drop every specification item after the block, because the
TITLEstate had noCODE_BEGINtransition and the closing fence then opened a phantom code block. This adds the missingTITLE → CODE_BLOCKtransition, a regression test (verified to fail without the fix), and a changelog entry.AI assistance note: analysis, fix, and test were written with Claude Code and reviewed by me;
mvn -T 1C verify(incl. self-trace) passes.🤖 Generated with Claude Code
https://claude.ai/code/session_014Hgw7DCVCJ6hEmxYz5cU8K