feat: message replacement - #31
Open
cfpwastaken wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-pass support for Matrix message editing via m.replace relations across message sending and rendering, so edited events can update existing message components instead of appearing as separate timeline entries.
Changes:
- Handle incoming
m.replacetimeline events inRoomViewby updating the existing message component. - Add “Replace” action for own messages and implement edit-message sending in
ChatInputusingm.new_content+m.relates_to. - Update all
ChatMessageBasesubclasses to render viagetContent()so replacements display the edited content.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/comps/views/RoomView.ts | Filters/handles m.replace timeline events and updates message component mapping |
| client/src/comps/events/RoomVideoMessage.ts | Use getContent() for replacement-aware rendering |
| client/src/comps/events/RoomTextMessage.ts | Use getContent() for replacement-aware rendering |
| client/src/comps/events/RoomNoticeMessage.ts | Use getContent() for replacement-aware rendering |
| client/src/comps/events/RoomImageMessage.ts | Use getContent() for replacement-aware rendering |
| client/src/comps/events/RoomFileMessage.ts | Use getContent() for replacement-aware rendering |
| client/src/comps/events/RoomEmoteMessage.ts | Use getContent() for replacement-aware rendering |
| client/src/comps/events/RoomAudioMessage.ts | Use getContent() for replacement-aware rendering |
| client/src/comps/events/EventBase.ts | Make message mutable to allow swapping in replacement events |
| client/src/comps/events/ChatMessageBase.ts | Add replacement support (context menu + replaceEvent + getContent) and UI marker |
| client/src/comps/ChatInput.ts | Add edit state + send edit events using m.replace |
| client/public/css/style.css | Style the replacement marker similarly to redacted text |
Comment on lines
88
to
+91
| const events = room.getLiveTimeline().getEvents() | ||
| this.msgList.reset(events) | ||
| this.msgList.reset(events.filter(e => { | ||
| return e.getContent()["m.relates_to"]?.rel_type !== "m.replace" | ||
| })) |
Comment on lines
+50
to
+52
| void comp.replaceEvent(event) | ||
| this.msgList.eventComponents.set(event.getId()!, comp) | ||
| return |
Comment on lines
+59
to
+63
| console.log("Event ID replaced:", oldId, "->", newEvent.getId()) | ||
| const comp = this.msgList.eventComponents.get(oldId) | ||
| this.msgList.eventComponents.delete(oldId) | ||
| this.msgList.eventComponents.set(newEvent.getId()!, comp!) | ||
| }) |
Comment on lines
+108
to
+115
| console.log("Resetting message:", msg.getId(), msg.getContent()) | ||
| if (msg.getContent()["m.relates_to"]?.rel_type === "m.replace" || msg.getOriginalContent() != msg.getContent()) { | ||
| const replacedMarker = document.createElement("span") | ||
| replacedMarker.className = "replaced-marker" | ||
| replacedMarker.textContent = " (replaced)" | ||
| this.contentElement.appendChild(replacedMarker) | ||
| return | ||
| } |
Comment on lines
+111
to
+120
| startReplacement(event: MatrixEvent) { | ||
| this.replacingEventId = event.getId() || null | ||
| const content = event.getContent() | ||
| if (content.msgtype === MsgType.Text) { | ||
| if (this.chatInput) { | ||
| this.chatInput.textContent = content.body as string || "" | ||
| this.chatInput.focus() | ||
| } | ||
| } | ||
| } |
Comment on lines
79
to
80
| console.log("Send MSG:", this.chatInput.innerText) | ||
| void createMessage() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec
m.replacerelations inChatInputm.replacerelations inRoomViewm.replacerelations in allChatMessageBasesubclassesTODO: