fix(desktop): show pending state while group descriptions generate - #16
Open
jakob1379 wants to merge 1 commit into
Open
fix(desktop): show pending state while group descriptions generate#16jakob1379 wants to merge 1 commit into
jakob1379 wants to merge 1 commit into
Conversation
The LLM metadata pass runs fire-and-forget after analyze, so descriptions landed minutes later with no signal they were coming — and the description row was not reserved until one arrived, so the block jumped on arrival. Reserve the slot and render a spinner while the pass is in flight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Group descriptions come only from the paid LLM metadata pass —
apply_heuristic_metadatafillsrisk,group_typeandimpact, and deliberately leavesdescriptionempty. In the desktop app that pass is fire-and-forget after analyze (describeGroups, App.tsx), so groups render immediately and descriptions appear minutes later with nothing having said they were coming.It also jumped:
reservesDescriptionis false while the pass is in flight, so the description row was not rendered at all and the summary block grew when the first description landed.Change
describingflag arounddescribeGroups..refine-spinner.Testing
npx tsc --noEmitclean. No E2E test: browser mode hasHAS_BACKEND === false, sodescribeGroupsreturns early and the flag never flips without mocking the Tauri bridge.