feat(ui): Analyze/Refine top-bar flow with incremental refinement - #17
Open
jakob1379 wants to merge 1 commit into
Open
feat(ui): Analyze/Refine top-bar flow with incremental refinement#17jakob1379 wants to merge 1 commit into
jakob1379 wants to merge 1 commit into
Conversation
Top bar: plain Analyze and Refine buttons replace the in-panel refinement banner. Analyze is blue before an analysis exists, red once one is loaded, and asks for a second click before discarding current groups. Refine greys out with a tooltip naming why it is unavailable. Refinement: incremental mode carries the previous refined grouping onto a fresh analysis and asks the LLM only for adjustments; in-flight jobs can be cancelled; a cached refinement is only auto-applied after re-analysis when its head commit and full file set match the fresh diff, otherwise it becomes the baseline for the next update. Review fixes: re-analysis cancels an in-flight refinement and rejects its pending stream so the top bar cannot stick on "Refining"; a job that finishes after a fresh analyze no longer overwrites it; the in-memory refinement baseline is cleared on every analyze so it cannot leak across repos; carried-over groups only keep files the fresh pass still groups; the PR head watcher no longer emits a phantom push when its seed poll failed. Adds a `typecheck:e2e` script so spec files are type-checked without launching a browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Top bar. Two plain buttons replace the in-panel refinement banner.
Refinement backend.
carry_over_grouping).RefinementResultrecordshead_shaand the coveredfiles; older cached JSON still deserializes (tested).File 'src/sepseeq/cli.py' not found in diffafter re-analyzing with a stale cached refinement.Also: PR/MR head polling with a "New commits" bar, and a
typecheck:e2enpm script so Playwright spec files are type-checked without a browser.Review
Three independent reviews were run on the first cut (OpenCodeReview delegation, an over-engineering pass, and a senior code review). Fixed in this PR:
analyzeno longer overwriteslast_analysis/last_refinement.analyze, and the frontend baseline flag reset, so a baseline cannot leak across repos/branches.start_refine_groups/refine_groupsfolded into one helper.output.giffrom the commit.Deliberately not taken: replacing the two-click confirm with
window.confirm(design choice), dropping theincrementalflag from the command API, and the largerwatch_git_head/watch_pr_headandls-remotededupe refactors. Those are follow-ups if wanted.Tests
cargo test -p diffcore-core -p diffcore-tauri: 2229 passed, 0 failed.npx tsc --noEmitandnpm run typecheck:e2e: clean.npm run build: OK.