Pre-compile pointer?

[hildjj]

What do you think about the ability to pre-compile a pointer? This would return a function that might be slightly faster for querying, but slower to create than the current approach. For applications where you're making the same query over and over, this would be a win.

[janl]

Could you mock up a sample API? I think I like the idea.

[hildjj]

I'd be happy to just implement it. I was thinking:

var get = jsonpointer.compile_get('/foo/bar');
var result = get(obj);
var set = jsonpointer.compile_set('/foo/bar');
var result = set(obj, value);

[janl]

Ah, sounds good. Just as a bikeshed, would something like this work?

var ptr = jsonpointer.compile('/foo/bar');
var result = get(obj, ptr);
var result2 = set(obj, ptr, value);

[hildjj]

Hm. How about:

var ptr = jsonpointer.compile('/foo/bar');
var result = ptr(obj);
var result2= ptr(obj, value);

[janl]

heh, nice, too! :)

My thinking is overloading get() and set() to accept a pointer string or a compiled pointer. To minimise API surface and all. If it is tedious to implement, I am happy with whatever you come up with.

[hildjj]

I understand your point, but I'm not sure what the compiled function returns in order to work for both get and set. I'm just testing the above; let's see how you feel about it when you've got something concrete.

[janl]

+1

[hildjj]

Check out this branch: hildjj@d5cdc65

[janl]

will do in the morning, thanks! :)

[hildjj]

I took a different approach that doesn't use eval anymore. I'm happier about the potential attack surface now. hildjj@1c373d5

[marcbachmann]

I've merged the compile functionality with the api

var pointer = jsonpointer.compile('/path')
pointer.get(object)
pointer.set(object, value)