Throw Error instances instead of strings - #12
Merged
Conversation
marcbachmann
commented
Feb 2, 2015
CollaboratorAuthor
Apparently node v0.4 isn't available anymore on travis. |
janl added a commit
that referenced
this pull request
Feb 12, 2015
Throw Error instances instead of strings
janl
commented
Feb 12, 2015
Owner
perfect, thanks, sorry for the delay! @marcbachmann fancy becoming a contributor here? |
marcbachmann
commented
Feb 12, 2015
CollaboratorAuthor
No problem. I'm not in a hurry. |
janl
commented
Feb 12, 2015
Owner
cool, welcome aboard ;) |
marcbachmann
commented
May 18, 2015
CollaboratorAuthor
@janl That change is still not published on npm. Can you add me there please. I currently can't publish. |
janl
commented
May 23, 2015
Owner
@marcbachmann added you to the jsonpointer npm owners. Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested in issue #11
There are no tests against .get calls that would result in an error. Do you need some?